Streaming output aligns with progress bar #39
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is ok 38b5c06 Thanks for trying the progress bar change. I feel this is too complex now and will be hard to maintain, also I think the performance will be uncertain. Will look to see if there is other/simpler way to do this. For now suggest if using progress bar, you redirect stdout/stderr to output files or disable stdout/stderr as mentioned in the manual:
If you want to make a PR for this change I would merge 38b5c06 |
|
Created another PR. Please feel free to close this one. |
|
Thanks @dreampuf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #38. I do not want to block the main thread. This is what I can get.
pb.suspenddoesn't take aFuture. So I have to take care of it by myself. It's kind of twisting between sync and async.Please let me know if there is a better way.